Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule-length: add count-comments configuration option #435

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

anderseknert
Copy link
Member

This is set to false by default, as we don't want to "punish" comments in rules.

Fixes #432

This is set to `false` by default, as we don't want to "punish"
comments in rules.

Fixes #432

Signed-off-by: Anders Eknert <[email protected]>
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it's good to give the option, but I feel like generally I'd not want to include comments in these rules.

@anderseknert anderseknert merged commit 935561d into main Nov 1, 2023
3 checks passed
@anderseknert anderseknert deleted the rule-length-comments branch November 1, 2023 11:04
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
This is set to `false` by default, as we don't want to "punish"
comments in rules.

Fixes StyraInc#432

Signed-off-by: Anders Eknert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rule-length should not count comments in body, unless configured to do so
2 participants